Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add enable-debug flag #791

Closed
wants to merge 4 commits into from
Closed

feat: add enable-debug flag #791

wants to merge 4 commits into from

Conversation

YeahNotSewerSide
Copy link
Member

Description

As default /debug endpoint is disabled on the node, and can be turned on with a supplied flag --enable-debug

issue

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Ran node in solo mode with debug enabled and disabled and called debug endpoints

Test Configuration:

  • Go Version: go1.22.1 linux/amd64
  • Hardware:
  • Docker Version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@YeahNotSewerSide YeahNotSewerSide requested a review from a team as a code owner July 16, 2024 10:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.51%. Comparing base (e6c91cb) to head (f5e0289).
Report is 7 commits behind head on master.

Files Patch % Lines
cmd/thor/main.go 0.00% 4 Missing ⚠️
api/api.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   62.08%   62.51%   +0.43%     
==========================================
  Files         203      203              
  Lines       18723    18732       +9     
==========================================
+ Hits        11624    11711      +87     
+ Misses       5997     5923      -74     
+ Partials     1102     1098       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenvechain
Copy link
Member

@YeahNotSewerSide looks like we need a PR to update the start command in e2e tests.

leszek-vechain
leszek-vechain reviewed Jul 16, 2024
View reviewed changes
cmd/thor/flags.go Outdated Show resolved Hide resolved
@YeahNotSewerSide YeahNotSewerSide mentioned this pull request Jul 16, 2024
Closed
@YeahNotSewerSide
Copy link
Member Author

@YeahNotSewerSide looks like we need a PR to update the start command in e2e tests.

vechain/thor-e2e-tests#28 - added a flag to the e2e tests

otherview
otherview previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, worth perhaps adding the api word in the flag/vars to make more explicit.

I wonder if we should probably merge this once we have the https://github.com/vechain/protocol-board-repo/issues/267 ready too ? Will ask offline 👍

cmd/thor/flags.go Outdated Show resolved Hide resolved
cmd/thor/main.go Outdated Show resolved Hide resolved
otherview
otherview approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm- Worth checking why the tests are failing.

@leszek-vechain
Copy link
Contributor

I think we need to modify the tests to have debug enabled too (Darren suggested that)

@YeahNotSewerSide
Copy link
Member Author

I think we need to modify the tests to have debug enabled too (Darren suggested that)

vechain/thor-e2e-tests#28 the pull request for that was open

@darrenvechain
Copy link
Member

Closing as we went with a different approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otherview otherview otherview approved these changes

@darrenvechain darrenvechain Awaiting requested review from darrenvechain

@leszek-vechain leszek-vechain Awaiting requested review from leszek-vechain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YeahNotSewerSide @codecov-commenter @darrenvechain @leszek-vechain @otherview